-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic in OnlineBeamSpotESProducer [12_0_X] #35334
Add logic in OnlineBeamSpotESProducer [12_0_X] #35334
Conversation
A new Pull Request was created by @francescobrivio for CMSSW_12_0_X. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @slava77, @jpata, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport of #35333 |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f4c15/18738/summary.html Comparison SummarySummary:
|
+alca |
@francescobrivio should we add an |
urgent |
@cmsbuild please test |
see a possible solution at #35373 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
hold
|
Pull request has been put on hold by @francescobrivio |
@francescobrivio @tvami #35373 needs more work. In particular an update of the Run3 MC Global Tags might be in order. I propose to unhold and merge this that is already signed. |
unhold
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
hello, is there anything preventing the merge of this? |
+1
|
PR description:
Backport of #35333: adds a real logic in
OnlineBeamSpotESProducer
in order to discriminate between the two BeamSpot workflows. This is needed for the Pilot Beam Test at the end of October.PR validation:
Tested locally using
RecoVertex/BeamSpotProducer/test/test_scalars.py
.Backport:
Backport of #35333